Skip to content

ci: fix release notes diff range after Release PR flow#7456

Merged
schiller-manuel merged 1 commit into
mainfrom
skip-ci-commit
May 21, 2026
Merged

ci: fix release notes diff range after Release PR flow#7456
schiller-manuel merged 1 commit into
mainfrom
skip-ci-commit

Conversation

@birkskyum
Copy link
Copy Markdown
Member

@birkskyum birkskyum commented May 21, 2026 •
edited by coderabbitai Bot
Loading

Fix scripts/create-github-release.mjs previous-release detection so GitHub release notes only contain changes since the prior release.

After moving to a separate changeset PR the commit title for releases is now ci: Version Packages where previously it was ci: changeset release. We have to adjust the create release script, so it also looks for ci: Version Packages so that it gets the right diff.

Summary by CodeRabbit

  • Chores
    • Updated release automation tooling to refine how release commits are identified and filtered during changelog generation.

Review Change Stack

@birkskyum birkskyum requested a review from a team as a code owner May 21, 2026 00:18
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5e027da4-0811-44c5-8783-ed1c1e2af786

📥 Commits

Reviewing files that changed from the base of the PR and between 65b4abe and 6c061a3.

📒 Files selected for processing (1)
  • scripts/create-github-release.mjs
📝 Walkthrough

Walkthrough

The PR updates the GitHub release creation script to recognize both ci: Version Packages and ci: changeset release commits when discovering release commits and filtering changelog entries, expanding from previously matching only changeset release commits.

Changes

Release commit detection and filtering

Layer / File(s) Summary
Git log filter and commit skip conditions
scripts/create-github-release.mjs		 The git log command for release logs is updated to match commits starting with either ci: Version Packages or ci: changeset release, and the changelog filtering skip condition is expanded to ignore both commit types.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • TanStack/router#7404: The main PR's create-github-release.mjs updates its git log-based discovery/filtering of ci: changeset release (and ci: Version Packages) commits, which is directly tied to the retrieved PR's release workflow changes that create version/publish commits with the ci: changeset release commit message.

Suggested reviewers

  • schiller-manuel

Poem

🐰 A script that once searched for just one kind of commit,
Now finds both the packages and changesets with git,
Two filters aligned, like lettuce and hay,
Release logs grow broader in every new way! 📝

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main fix: updating release notes diff range detection after changing to a Release PR workflow where commit titles changed from 'ci: changeset release' to 'ci: Version Packages'.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skip-ci-commit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 21, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6c061a3

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 16s View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-21 00:21:24 UTC

@birkskyum birkskyum changed the title grep ci: Version Packages ci: fix release notes diff range after Release PR flow May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@schiller-manuel schiller-manuel merged commit e2896b5 into main May 21, 2026
9 checks passed
@schiller-manuel schiller-manuel deleted the skip-ci-commit branch May 21, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schiller-manuel schiller-manuel schiller-manuel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum @schiller-manuel